Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add submit options to the cluster configuration #35

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Conversation

joaander
Copy link
Member

Description

Add submit_option to the cluster configuration. These submit options are passed in every submitted jobs.

Motivation and context

Delta and Frontier both have --constraints flags that should (almost) always be set. I set these values by default. In most cases, setting these constraints have no undesirable side effects. In cases where they are a problem, users can override the setting with action specific submit_options or a custom clusters.toml.

How has this been tested?

Validation tests pass on Delta and Frontier. Unit tests ensure that the new submit_options behaves correctly.

Checklist:

  • I have reviewed the Contributor Guidelines.
  • I agree with the terms of the Row Contributor Agreement.
  • My name is on the list of contributors (doc/src/contributors.md) in the pull request source branch.
  • I have added a change log entry to doc/src/release-notes.md.

@joaander joaander merged commit cb3bc5b into trunk Aug 15, 2024
17 checks passed
@joaander joaander deleted the constraints branch August 15, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant